public inbox for kernel-janitors@vger.kernel.org
 help / color / mirror / Atom feed
From: Dan Carpenter <dan.carpenter@oracle.com>
To: kernel-janitors@vger.kernel.org
Subject: Re: [staging:staging-next 115/274] drivers/staging/ced1401/usb1401.c:1065 Handle1401Esc() error: dou
Date: Mon, 22 Oct 2012 11:43:22 +0000	[thread overview]
Message-ID: <20121022114322.GC7329@mwanda> (raw)
In-Reply-To: <CAHdPZaPfEFkPmH_46uFQMMU4aiN1RmxFftMk02M58S4Z_CWxMw@mail.gmail.com>

On Mon, Oct 22, 2012 at 12:42:49PM +0200, Alois Schloegl wrote:
> Hi,
> 
> 
> Please include (Greg Smith <greg@ced.co.uk>) into any communication.
> Greg Smith from CED noticed that there is no kfree, causing a memory
> leak, and memset() has been removed, thus tx->used was not cleared.
> 
> The patch below should fix this.

This isn't the right way to submit patches.  Run checkpatch over the
patch.  (No signed off by etc).  Also it's totally corrupted.  Email
it to yourself, save the email, cat raw_email.txt | git am.  Look
over the changelog.  When that works, then resend.

Read Documentation/SubmittingPatches for more info.

regards,
dan carpenter

  parent reply	other threads:[~2012-10-22 11:43 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-10-07 12:56 [staging:staging-next 115/274] drivers/staging/ced1401/usb1401.c:1065 Handle1401Esc() error: dou devendra.aaru
2012-10-22 10:42 ` Alois Schloegl
2012-10-22 11:43 ` Dan Carpenter [this message]
2012-10-22 15:52 ` devendra.aaru

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20121022114322.GC7329@mwanda \
    --to=dan.carpenter@oracle.com \
    --cc=kernel-janitors@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox