* [patch] drm: potential NULL dereference with debugging enabled
@ 2012-10-26 6:59 Dan Carpenter
0 siblings, 0 replies; only message in thread
From: Dan Carpenter @ 2012-10-26 6:59 UTC (permalink / raw)
To: David Airlie; +Cc: kernel-janitors, dri-devel
We check whether this pointer is NULL a few lines later in the function
so probably we should check here too.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
This is a static checker fix.
diff --git a/drivers/gpu/drm/drm_lock.c b/drivers/gpu/drm/drm_lock.c
index d752c96..036253e 100644
--- a/drivers/gpu/drm/drm_lock.c
+++ b/drivers/gpu/drm/drm_lock.c
@@ -68,7 +68,8 @@ int drm_lock(struct drm_device *dev, void *data, struct drm_file *file_priv)
DRM_DEBUG("%d (pid %d) requests lock (0x%08x), flags = 0x%08x\n",
lock->context, task_pid_nr(current),
- master->lock.hw_lock->lock, lock->flags);
+ master->lock.hw_lock ? master->lock.hw_lock->lock : -1,
+ lock->flags);
add_wait_queue(&master->lock.lock_queue, &entry);
spin_lock_bh(&master->lock.spinlock);
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2012-10-26 6:59 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-10-26 6:59 [patch] drm: potential NULL dereference with debugging enabled Dan Carpenter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).