From: David Sterba <dave@jikos.cz>
To: Julia Lawall <Julia.Lawall@lip6.fr>
Cc: Chris Mason <chris.mason@fusionio.com>,
kernel-janitors@vger.kernel.org, linux-btrfs@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/8] fs/btrfs: drop if around WARN_ON
Date: Mon, 05 Nov 2012 15:39:02 +0000 [thread overview]
Message-ID: <20121105153902.GK3102@twin.jikos.cz> (raw)
In-Reply-To: <1351974625-10282-2-git-send-email-Julia.Lawall@lip6.fr>
On Sat, Nov 03, 2012 at 09:30:18PM +0100, Julia Lawall wrote:
> From: Julia Lawall <Julia.Lawall@lip6.fr>
>
> Just use WARN_ON rather than an if containing only WARN_ON(1).
>
> A simplified version of the semantic patch that makes this transformation
> is as follows: (http://coccinelle.lip6.fr/)
>
> // <smpl>
> @@
> expression e;
> @@
> - if (e) WARN_ON(1);
> + WARN_ON(e);
> // </smpl>
>
> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Reviewed-by: David Sterba <dsterba@suse.cz>
next prev parent reply other threads:[~2012-11-05 15:39 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-03 20:30 [PATCH 0/8] drop if around WARN_ON Julia Lawall
2012-11-03 20:30 ` [PATCH 1/8] fs/btrfs: " Julia Lawall
2012-11-05 15:39 ` David Sterba [this message]
2012-11-03 20:30 ` [PATCH 2/8] drivers/scsi/bfa/bfa_svc.c: " Julia Lawall
2012-11-03 20:30 ` [PATCH 3/8] arch/x86/kernel/cpu/mtrr/cleanup.c: " Julia Lawall
2012-11-03 20:30 ` [PATCH 4/8] fs/ext3/inode.c: " Julia Lawall
2012-11-06 23:04 ` Jan Kara
2012-11-03 20:30 ` [PATCH 5/8] drivers/scsi/qla2xxx/qla_nx.c: " Julia Lawall
2012-11-03 20:30 ` [PATCH 6/8] arch/arm/mach-omap2/dpll3xxx.c: " Julia Lawall
2012-12-14 18:53 ` Tony Lindgren
2012-11-03 20:30 ` [PATCH 7/8] drivers/scsi/scsi_transport_fc.c: " Julia Lawall
2012-11-03 20:30 ` [PATCH 8/8] drivers/net/wireless/ath/ath6kl/hif.c: " Julia Lawall
2012-11-16 11:39 ` Kalle Valo
2012-11-04 14:59 ` [PATCH 0/8] " Sasha Levin
2012-11-04 15:57 ` Julia Lawall
2012-11-04 16:00 ` Sasha Levin
2012-11-04 16:16 ` Julia Lawall
2012-11-05 2:47 ` Sasha Levin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121105153902.GK3102@twin.jikos.cz \
--to=dave@jikos.cz \
--cc=Julia.Lawall@lip6.fr \
--cc=chris.mason@fusionio.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox