From: Dan Carpenter <dan.carpenter@oracle.com>
To: kernel-janitors@vger.kernel.org
Subject: Re: [patch] USB: usbtest: prevent a divide by zero bug
Date: Sat, 17 Nov 2012 18:10:56 +0000 [thread overview]
Message-ID: <20121117181055.GP11515@mwanda> (raw)
In-Reply-To: <20121117150610.GA19951@elgon.mountain>
On Sat, Nov 17, 2012 at 06:48:55PM +0100, walter harms wrote:
>
>
> Am 17.11.2012 16:06, schrieb Dan Carpenter:
> > If param->length is zero, then this could lead to a divide by zero bug
> > later in the function when we do: size %= max;
> >
> > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> >
> > diff --git a/drivers/usb/misc/usbtest.c b/drivers/usb/misc/usbtest.c
> > index f10bd97..7667b12 100644
> > --- a/drivers/usb/misc/usbtest.c
> > +++ b/drivers/usb/misc/usbtest.c
> > @@ -423,6 +423,9 @@ alloc_sglist(int nents, int max, int vary)
> > unsigned i;
> > unsigned size = max;
> >
> > + if (max = 0)
> > + return NULL;
> > +
>
> maybe you should be more defensive and check from (max <= 0)
>
Nah... Testing for = 0 is ok.
regards,
dan carpenter
next prev parent reply other threads:[~2012-11-17 18:10 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-17 15:06 [patch] USB: usbtest: prevent a divide by zero bug Dan Carpenter
2012-11-17 17:48 ` walter harms
2012-11-17 18:10 ` Dan Carpenter [this message]
2012-11-20 17:44 ` Sebastian Andrzej Siewior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121117181055.GP11515@mwanda \
--to=dan.carpenter@oracle.com \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox