Re: [patch] UBIFS: use kmalloc_array() in recomp_data_node()

Artem Bityutskiy
2012-11-22T10:31:37Z

[-- Attachment #1: Type: text/plain, Size: 392 bytes --]

On Sat, 2012-11-17 at 18:11 +0300, Dan Carpenter wrote:
> out_len = le32_to_cpu(dn->size);
> - buf = kmalloc(out_len * WORST_COMPR_FACTOR, GFP_NOFS);
> + buf = kmalloc_array(out_len, WORST_COMPR_FACTOR, GFP_NOFS);
> if (!buf)
> return -ENOMEM;

I think this makes the code unreadable, because we really allocate a
buffer, not an array.

--
Best Regards,
Artem Bityutskiy

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]