From: Dan Carpenter <dan.carpenter@oracle.com>
To: Theodore Ts'o <tytso@mit.edu>
Cc: Andreas Dilger <adilger.kernel@dilger.ca>,
linux-ext4@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: [patch] ext4: unneeded variable in ext4_try_add_inline_entry()
Date: Wed, 05 Dec 2012 08:08:37 +0000 [thread overview]
Message-ID: <20121205080836.GA10259@elgon.mountain> (raw)
We never actually use "backup_buf" so I have removed it.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/fs/ext4/inline.c b/fs/ext4/inline.c
index 1fe0cc4..26e4218 100644
--- a/fs/ext4/inline.c
+++ b/fs/ext4/inline.c
@@ -1224,7 +1224,7 @@ int ext4_try_add_inline_entry(handle_t *handle, struct dentry *dentry,
struct inode *inode)
{
int ret, inline_size;
- void *inline_start, *backup_buf = NULL;
+ void *inline_start;
struct ext4_iloc iloc;
struct inode *dir = dentry->d_parent->d_inode;
@@ -1276,7 +1276,6 @@ int ext4_try_add_inline_entry(handle_t *handle, struct dentry *dentry,
ret = ext4_convert_inline_data_nolock(handle, dir, &iloc);
out:
- kfree(backup_buf);
ext4_mark_inode_dirty(handle, dir);
up_write(&EXT4_I(dir)->xattr_sem);
brelse(iloc.bh);
next reply other threads:[~2012-12-05 8:08 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-05 8:08 Dan Carpenter [this message]
2012-12-06 17:23 ` [patch] ext4: unneeded variable in ext4_try_add_inline_entry() Theodore Ts'o
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121205080836.GA10259@elgon.mountain \
--to=dan.carpenter@oracle.com \
--cc=adilger.kernel@dilger.ca \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-ext4@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).