Re: [PATCH 5/5] spi: fix return value check in hspi_probe().

Grant Likely
2012-12-22T09:56:20Z

On Wed, 19 Dec 2012 19:39:14 +0300, Dan Carpenter <dan.carpenter@oracle.com> wrote:
> On Wed, Dec 19, 2012 at 03:11:54PM +0000, Grant Likely wrote:
> > On Tue, 11 Dec 2012 16:36:27 -0800 (PST), Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> wrote:
> > >
> > > Hi
> > >
> > > > According to its documentation, clk_get() returns a "valid IS_ERR() condition
> > > > containing errno", so we should call IS_ERR() rather than a NULL check.
> > > >
> > > > Signed-off-by: Cyril Roelandt <tipecaml@gmail.com>
> > >
> > > Acked-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> >
> > Applied, thanks.
>
> In another thread, we were just talking about who clk_get() can
> return a NULL if !CONFIG_HAVE_CLK. That might change to match the
> documentation later... Not sure.

So what is the solution here? Will the dummy clk_get() be changed, or is
there more work needed on the drivers?

/me stifles a rant about the PTR_ERR pattern

g.