public inbox for kernel-janitors@vger.kernel.org
 help / color / mirror / Atom feed
From: Dan Carpenter <dan.carpenter@oracle.com>
To: kernel-janitors@vger.kernel.org
Subject: re: VMCI: queue pairs implementation.
Date: Thu, 10 Jan 2013 19:32:39 +0000	[thread overview]
Message-ID: <20130110193238.GB17997@elgon.mountain> (raw)

Hello George Zhang,

This is a semi-automatic email about new static checker warnings.

The patch 06164d2b72aa: "VMCI: queue pairs implementation." from Jan
8, 2013, leads to the following Smatch complaint:

drivers/misc/vmw_vmci/vmci_queue_pair.c:3356 vmci_qpair_dequev()
	 warn: variable dereferenced before check 'qpair' (see line 3354)

drivers/misc/vmw_vmci/vmci_queue_pair.c
  3353	
  3354		qp_lock(qpair);
                        ^^^^^^
dereference.

  3355	
  3356		if (!qpair || !iov)
                     ^^^^^
test.

  3357			return VMCI_ERROR_INVALID_ARGS;
  3358	

regards,
dan carpenter

             reply	other threads:[~2013-01-10 19:32 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-01-10 19:32 Dan Carpenter [this message]
2013-01-10 19:36 ` VMCI: queue pairs implementation George Zhang
2014-01-30 11:51 ` Dan Carpenter
2014-01-30 11:52 ` Dan Carpenter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130110193238.GB17997@elgon.mountain \
    --to=dan.carpenter@oracle.com \
    --cc=kernel-janitors@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox