From: David Miller <davem@davemloft.net>
To: dan.carpenter@oracle.com
Cc: benve@cisco.com, roprabhu@cisco.com, neepatel@cisco.com,
nistrive@cisco.com, netdev@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [patch] enic: change sprintf() to snprintf()
Date: Fri, 18 Jan 2013 19:35:22 +0000 [thread overview]
Message-ID: <20130118.143522.943294381617599481.davem@davemloft.net> (raw)
In-Reply-To: <20130118074618.GC31793@elgon.mountain>
From: Dan Carpenter <dan.carpenter@oracle.com>
Date: Fri, 18 Jan 2013 10:46:18 +0300
> These are copying data into 16 char arrays. They all specify that the
> first string can't be more than 11 characters but once you add on the
> "-rx-" and the NUL character there isn't space for the %d.
>
> The first string is probably never going to be 11 characters, but if it
> is then let's truncate the string instead of corrupting memory.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Applied to net-next, thanks.
prev parent reply other threads:[~2013-01-18 19:35 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-18 7:46 [patch] enic: change sprintf() to snprintf() Dan Carpenter
2013-01-18 19:35 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130118.143522.943294381617599481.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=benve@cisco.com \
--cc=dan.carpenter@oracle.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=neepatel@cisco.com \
--cc=netdev@vger.kernel.org \
--cc=nistrive@cisco.com \
--cc=roprabhu@cisco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox