Re: [patch] f2fs: use _safe() version of list_for_each

[Dmitry Torokhov <dmitry.torokhov@gmail.com>]

On Mon, Jan 21, 2013 at 09:39:43AM +0900, Namjae Jeon wrote:
> 2013/1/21, Dan Carpenter <dan.carpenter@oracle.com>:
> > This is calling list_del() inside a loop which is a problem when we try
> > move to the next item on the list.  I've converted it to use the _safe
> > version.  And also, as a cleanup, I've converted it to use
> > list_for_each_entry instead of list_for_each.
> >
> Hi Dan.
> I can't understand why this patch is needed yet.
> Could you elaborate more ?

A simple rule of thumb: if you modify list inside the loop you need to
use the _safe variant of the iterator, since once element is deleted you
can't get from it to the next element.

Thanks.

-- 
Dmitry