From mboxrd@z Thu Jan 1 00:00:00 1970 From: Arnaldo Carvalho de Melo Date: Wed, 23 Jan 2013 21:56:13 +0000 Subject: Re: [PATCH 11/15] tools/lib/traceevent/event-parse.c: adjust duplicate test Message-Id: <20130123215613.GC6687@ghostprotocols.net> List-Id: References: <1358773378-4700-1-git-send-email-Julia.Lawall@lip6.fr> <1358773378-4700-12-git-send-email-Julia.Lawall@lip6.fr> <1358952137.21576.117.camel@gandalf.local.home> In-Reply-To: <1358952137.21576.117.camel@gandalf.local.home> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Steven Rostedt Cc: Sasha Levin , Julia Lawall , linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, Namhyung Kim Em Wed, Jan 23, 2013 at 09:42:17AM -0500, Steven Rostedt escreveu: > On Mon, 2013-01-21 at 14:02 +0100, Julia Lawall wrote: > > From: Julia Lawall > > > > Delete successive tests to the same location. Field was already tested. > > Alloc_arg can fail, so test that value instead. > > > > A simplified version of the semantic match that finds this problem is as > > follows: (http://coccinelle.lip6.fr/) This one was fixed already by the patch below, that is in my perf/core branch: commit 9b9af6013045d58e95ecce62a1cfb34b150b7a8d Author: Sasha Levin Date: Fri Dec 21 15:00:58 2012 -0500 tools lib traceevent: test correct variable after allocation we've tested the wrong variable for allocation failure, fix it to test the right one.