From: Dan Carpenter <dan.carpenter@oracle.com>
To: walter harms <wharms@bfs.de>
Cc: Greg KH <gregkh@linuxfoundation.org>,
Kumar Amit Mehta <gmate.amit@gmail.com>,
devel@driverdev.osuosl.org, kernel-janitors@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] staging: comedi: drivers: usbduxfast.c: fix for DMA buffers on stack
Date: Sat, 23 Feb 2013 17:34:42 +0000 [thread overview]
Message-ID: <20130223173442.GL9138@mwanda> (raw)
In-Reply-To: <5128E76F.1000607@bfs.de>
On Sat, Feb 23, 2013 at 04:59:43PM +0100, walter harms wrote:
> >> or is it possible to pass one byte
> >> in a register ? (aka char/int) without allocating ?
> >
> > Nope, the USB host controllers must be able to DMA to this memory
> > location, so you have to allocate it dynamically, sorry.
> >
> > thanks,
>
> thx for clarification.
>
> @Kumar Amit Mehta:
> Would you mind to add this as comment ? Allocating one byte does not
> look clever so maybe will come up with the idea of changing that.
>
That can't happen. The reason is already recorded in the git
history. Greg and Ian know that DMA to stack memory doesn't work.
Most maintainers know about that. If someone changed it back then
Fengguang would send an automatic email about it as soon as it was
committed to a public git tree.
regards,
dan carpenter
next prev parent reply other threads:[~2013-02-23 17:34 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-22 18:07 [PATCH 2/2] staging: comedi: drivers: usbduxfast.c: fix for DMA buffers on stack Kumar Amit Mehta
2013-02-22 18:58 ` walter harms
2013-02-22 19:06 ` Greg KH
2013-02-23 15:59 ` walter harms
2013-02-23 17:34 ` Dan Carpenter [this message]
2013-02-23 18:13 ` walter harms
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130223173442.GL9138@mwanda \
--to=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=gmate.amit@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=wharms@bfs.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).