From: Dan Carpenter <dan.carpenter@oracle.com>
To: kernel-janitors@vger.kernel.org
Subject: Re: [patch 1/2] wlan-ng: clean up prism2sta_inf_chinforesults()
Date: Wed, 27 Feb 2013 21:56:30 +0000 [thread overview]
Message-ID: <20130227215630.GR9138@mwanda> (raw)
In-Reply-To: <20130227051206.GA22703@longonot.mountain>
On Wed, Feb 27, 2013 at 10:42:23PM +0100, walter harms wrote:
> but i am missing the point why where are two counters.
> i is simple. it is used to check the bitfield hw->channel_info.results.scanchannels
> n is increased only the when a bit is set. So it would be more easy to simply
> count the bits and run the loop about that number.
> But i can also imagine that the bitfield act as "enable" and the author actualy
> should read &inf->info.chinforesult.result[i];
>
> perhaps i am missing the point, could someone tell me were i am wrong ?
>
I don't understand how you're confused. You've described the code
perfectly. One is incremented for every iteration and one is only
incremented if we find what we're looking for.
Anyway, the point of the cleanup was just so I could add a range
check in patch 2/2 but the original code was too ugly to look at.
regards,
dan carpenter
next prev parent reply other threads:[~2013-02-27 21:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-27 5:12 [patch 1/2] wlan-ng: clean up prism2sta_inf_chinforesults() Dan Carpenter
2013-02-27 21:42 ` walter harms
2013-02-27 21:56 ` Dan Carpenter [this message]
2013-02-27 22:13 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130227215630.GR9138@mwanda \
--to=dan.carpenter@oracle.com \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox