From: Dan Carpenter <dan.carpenter@oracle.com>
To: Nestor Lopez Casado <nlopezcasad@logitech.com>
Cc: Benjamin Tissoires <benjamin.tissoires@gmail.com>,
Jiri Kosina <jkosina@suse.cz>,
"open list:HID CORE LAYER" <linux-input@vger.kernel.org>,
kernel-janitors@vger.kernel.org
Subject: Re: [patch] HID: hid-logitech-dj: add some range checks
Date: Tue, 05 Mar 2013 17:45:35 +0000 [thread overview]
Message-ID: <20130305174535.GD9189@mwanda> (raw)
In-Reply-To: <CAE7qMrouxdpjtBRpTUjKBdiAr-wwhy8x3M23Q_twP+kkTFFALA@mail.gmail.com>
On Tue, Mar 05, 2013 at 05:34:08PM +0100, Nestor Lopez Casado wrote:
> > If you want to add a check, it need to be in logi_dj_recv_forward_report().
> > The current access to djrcv_dev->paired_dj_devices[] in
> > delayedwork_callback() has been removed in latest HID tree:
> > https://git.kernel.org/cgit/linux/kernel/git/jikos/hid.git/log/?h=for-3.10/logitech
> The test could be added there. It would be quite defensive though, as
> we should always get the right device indexes.
Ah... I appologize for the noise. I misunderstood how
hid_input_report() works. I thought it could be called with user
supplied parameters.
Never mind.
regards,
dan carpenter
prev parent reply other threads:[~2013-03-05 17:45 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-05 13:06 [patch] HID: hid-logitech-dj: add some range checks Dan Carpenter
2013-03-05 14:47 ` Benjamin Tissoires
2013-03-05 16:34 ` Nestor Lopez Casado
2013-03-05 17:45 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130305174535.GD9189@mwanda \
--to=dan.carpenter@oracle.com \
--cc=benjamin.tissoires@gmail.com \
--cc=jkosina@suse.cz \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=nlopezcasad@logitech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox