From: Shawn Guo <shawn.guo@linaro.org>
To: kernel-janitors@vger.kernel.org
Subject: Re: [patch] reset: NULL deref on allocation failure
Date: Thu, 04 Apr 2013 11:56:50 +0000 [thread overview]
Message-ID: <20130404115648.GD21790@S2101-09.ap.freescale.net> (raw)
In-Reply-To: <20130403050253.GA31179@longonot.mountain>
Philipp,
On Thu, Apr 04, 2013 at 09:49:36AM +0200, Philipp Zabel wrote:
> Hi Dan,
>
> Am Mittwoch, den 03.04.2013, 08:02 +0300 schrieb Dan Carpenter:
> > "rstc" is NULL here and we should use "rcdev" instead of "rstc->rcdev".
> >
> > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> >
> > diff --git a/drivers/reset/core.c b/drivers/reset/core.c
> > index a258277..d1b6089 100644
> > --- a/drivers/reset/core.c
> > +++ b/drivers/reset/core.c
> > @@ -181,7 +181,7 @@ struct reset_control *reset_control_get(struct device *dev, const char *id)
> >
> > rstc = kzalloc(sizeof(*rstc), GFP_KERNEL);
> > if (!rstc) {
> > - module_put(rstc->rcdev->owner);
> > + module_put(rcdev->owner);
> > return ERR_PTR(-ENOMEM);
> > }
>
> Acked-by: Philipp Zabel <p.zabel@pengutronix.de>
>
I think you should take care of the patch to have it merged through the
same path that the 'reset API' series goes to mainline.
Shawn
next prev parent reply other threads:[~2013-04-04 11:56 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-03 5:02 [patch] reset: NULL deref on allocation failure Dan Carpenter
2013-04-04 7:49 ` Philipp Zabel
2013-04-04 11:56 ` Shawn Guo [this message]
2013-04-04 12:13 ` Dan Carpenter
2013-04-09 8:08 ` Philipp Zabel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130404115648.GD21790@S2101-09.ap.freescale.net \
--to=shawn.guo@linaro.org \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox