From: Dan Carpenter <dan.carpenter@oracle.com>
To: Sumit Semwal <sumit.semwal@linaro.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Dave Airlie <airlied@redhat.com>,
linaro-mm-sig@lists.linaro.org, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org, kbuild@01.org
Subject: [patch 1/2 -next] dma-buf: double unlock in debugfs code
Date: Thu, 11 Apr 2013 06:23:39 +0000 [thread overview]
Message-ID: <20130411062339.GA7603@elgon.mountain> (raw)
We unlock here when we failed to take the lock.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
This is in linux-next, and I think the debugfs code is only in Sumit's
tree.
diff --git a/drivers/base/dma-buf.c b/drivers/base/dma-buf.c
index 466476f..174cd2c 100644
--- a/drivers/base/dma-buf.c
+++ b/drivers/base/dma-buf.c
@@ -593,7 +593,7 @@ static int dma_buf_describe(struct seq_file *s)
if (ret) {
seq_printf(s,
"\tERROR locking buffer object: skipping\n");
- goto skip_buffer;
+ continue;
}
seq_printf(s, "\t");
@@ -618,7 +618,6 @@ static int dma_buf_describe(struct seq_file *s)
count++;
size += buf_obj->size;
-skip_buffer:
mutex_unlock(&buf_obj->lock);
}
next reply other threads:[~2013-04-11 6:23 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-11 6:23 Dan Carpenter [this message]
2013-04-11 6:27 ` [kbuild] [patch 1/2 -next] dma-buf: double unlock in debugfs code Dan Carpenter
2013-04-11 19:40 ` Greg Kroah-Hartman
[not found] ` <CAO_48GHvAUmVmmZyHiEXzN3nWtTjC9iz-hEo-z3GrR2T-LZ-0w@mail.gmail.com>
2013-04-12 5:59 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130411062339.GA7603@elgon.mountain \
--to=dan.carpenter@oracle.com \
--cc=airlied@redhat.com \
--cc=gregkh@linuxfoundation.org \
--cc=kbuild@01.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linaro-mm-sig@lists.linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sumit.semwal@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox