* [patch 1/2 -next] dma-buf: double unlock in debugfs code
@ 2013-04-11 6:23 Dan Carpenter
2013-04-11 6:27 ` [kbuild] " Dan Carpenter
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Dan Carpenter @ 2013-04-11 6:23 UTC (permalink / raw)
To: Sumit Semwal
Cc: Greg Kroah-Hartman, Dave Airlie, linaro-mm-sig, linux-kernel,
kernel-janitors, kbuild
We unlock here when we failed to take the lock.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
This is in linux-next, and I think the debugfs code is only in Sumit's
tree.
diff --git a/drivers/base/dma-buf.c b/drivers/base/dma-buf.c
index 466476f..174cd2c 100644
--- a/drivers/base/dma-buf.c
+++ b/drivers/base/dma-buf.c
@@ -593,7 +593,7 @@ static int dma_buf_describe(struct seq_file *s)
if (ret) {
seq_printf(s,
"\tERROR locking buffer object: skipping\n");
- goto skip_buffer;
+ continue;
}
seq_printf(s, "\t");
@@ -618,7 +618,6 @@ static int dma_buf_describe(struct seq_file *s)
count++;
size += buf_obj->size;
-skip_buffer:
mutex_unlock(&buf_obj->lock);
}
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [kbuild] [patch 1/2 -next] dma-buf: double unlock in debugfs code
2013-04-11 6:23 [patch 1/2 -next] dma-buf: double unlock in debugfs code Dan Carpenter
@ 2013-04-11 6:27 ` Dan Carpenter
2013-04-11 19:40 ` Greg Kroah-Hartman
[not found] ` <CAO_48GHvAUmVmmZyHiEXzN3nWtTjC9iz-hEo-z3GrR2T-LZ-0w@mail.gmail.com>
2 siblings, 0 replies; 4+ messages in thread
From: Dan Carpenter @ 2013-04-11 6:27 UTC (permalink / raw)
To: Sumit Semwal
Cc: Greg Kroah-Hartman, kernel-janitors, linux-kernel, linaro-mm-sig,
kbuild, Dave Airlie
Oops... I mailed that prematurely. There isn't a [patch 2/2].
regards,
dan carpenter
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [patch 1/2 -next] dma-buf: double unlock in debugfs code
2013-04-11 6:23 [patch 1/2 -next] dma-buf: double unlock in debugfs code Dan Carpenter
2013-04-11 6:27 ` [kbuild] " Dan Carpenter
@ 2013-04-11 19:40 ` Greg Kroah-Hartman
[not found] ` <CAO_48GHvAUmVmmZyHiEXzN3nWtTjC9iz-hEo-z3GrR2T-LZ-0w@mail.gmail.com>
2 siblings, 0 replies; 4+ messages in thread
From: Greg Kroah-Hartman @ 2013-04-11 19:40 UTC (permalink / raw)
To: Dan Carpenter
Cc: Sumit Semwal, Dave Airlie, linaro-mm-sig, linux-kernel,
kernel-janitors, kbuild
On Thu, Apr 11, 2013 at 09:23:39AM +0300, Dan Carpenter wrote:
> We unlock here when we failed to take the lock.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> ---
> This is in linux-next, and I think the debugfs code is only in Sumit's
> tree.
Yes, it's not in mine, so I can't take this, sorry. Sumit, please apply
this:
Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
^ permalink raw reply [flat|nested] 4+ messages in thread[parent not found: <CAO_48GHvAUmVmmZyHiEXzN3nWtTjC9iz-hEo-z3GrR2T-LZ-0w@mail.gmail.com>]
* Re: [patch 1/2 -next] dma-buf: double unlock in debugfs code
[not found] ` <CAO_48GHvAUmVmmZyHiEXzN3nWtTjC9iz-hEo-z3GrR2T-LZ-0w@mail.gmail.com>
@ 2013-04-12 5:59 ` Dan Carpenter
0 siblings, 0 replies; 4+ messages in thread
From: Dan Carpenter @ 2013-04-12 5:59 UTC (permalink / raw)
To: Sumit Semwal
Cc: Greg Kroah-Hartman, kbuild, Linaro MM SIG, kernel-janitors,
Dave Airlie, LKML
On Fri, Apr 12, 2013 at 08:43:05AM +0530, Sumit Semwal wrote:
> Hi Dan,
>
> On Apr 11, 2013 11:54 AM, "Dan Carpenter" <dan.carpenter@oracle.com> wrote:
> >
> > We unlock here when we failed to take the lock.
> Thanks for catching this; I will add it to the for-next queue.
>
> Could I merge this change with the main patch while submitting to mainline?
> With an attribution to you, of course.
Yeah. Just merge it. Don't stress about attribution.
regards,
dan carpenter
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2013-04-12 5:59 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-04-11 6:23 [patch 1/2 -next] dma-buf: double unlock in debugfs code Dan Carpenter
2013-04-11 6:27 ` [kbuild] " Dan Carpenter
2013-04-11 19:40 ` Greg Kroah-Hartman
[not found] ` <CAO_48GHvAUmVmmZyHiEXzN3nWtTjC9iz-hEo-z3GrR2T-LZ-0w@mail.gmail.com>
2013-04-12 5:59 ` Dan Carpenter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox