From: Dan Carpenter <dan.carpenter@oracle.com>
To: kernel-janitors@vger.kernel.org
Subject: Re: [Patch] Staging: winbond: Made local functions static
Date: Thu, 30 May 2013 13:58:39 +0000 [thread overview]
Message-ID: <20130530135839.GK23932@mwanda> (raw)
In-Reply-To: <51A6E81C.2000303@gmail.com>
On Thu, May 30, 2013 at 06:51:48PM +0530, Harsh Kumar wrote:
> The v2 patch will be over & above the changes that have been by my
> previous patch, right?
A v2 patch is a replacement for the first patch. There is a formula
to it:
1) Reply to the original patch.
2) The subject changes to [patch v2] Staging: winbond: Made local functions static
3) Use the same changelog as before.
4) After the signed off by line put:
---
v2: whitespace changes
That line gets chopped out of the commit message save in the git
log.
5) The same patch but without the whitespace changes
Btw, once Greg sends you an email that your patch has been applied
then it's too late to send a v2 patch and everything needs to be
done as a separate patch.
I feel like if Greg has already merged the patch then just forget
about it. We'll fix it up later. No worries. Patch review isn't
meant as a punishment for newbie stuff. ;)
regards,
dan carpenter
prev parent reply other threads:[~2013-05-30 13:58 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-30 5:48 [Patch] Staging: winbond: Made local functions static Harsh Kumar
2013-05-30 9:20 ` walter harms
2013-05-30 9:40 ` Pavel Machek
2013-05-30 12:13 ` Dan Carpenter
2013-05-30 12:18 ` Dan Carpenter
2013-05-30 13:08 ` Dan Carpenter
2013-05-30 13:33 ` Harsh Kumar
2013-05-30 13:58 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130530135839.GK23932@mwanda \
--to=dan.carpenter@oracle.com \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox