From: Dan Carpenter <dan.carpenter@oracle.com>
To: kernel-janitors@vger.kernel.org
Subject: Re: [patch] leds: renesas-tpu: cleanup a small type issue
Date: Fri, 31 May 2013 05:45:42 +0000 [thread overview]
Message-ID: <20130531054541.GO23987@mwanda> (raw)
In-Reply-To: <20130529070150.GC25133@debian>
On Thu, May 30, 2013 at 11:01:34AM -0700, Bryan Wu wrote:
> On Thu, May 30, 2013 at 5:02 AM, Dan Carpenter <dan.carpenter@oracle.com> wrote:
> > On Thu, May 30, 2013 at 10:59:35AM +0200, walter harms wrote:
> >>
> >>
> >> Am 29.05.2013 23:15, schrieb Dan Carpenter:
> >> > On Wed, May 29, 2013 at 07:34:39PM +0200, walter harms wrote:
> >> >
> >> >> int would be a more "natural" choice.
> >> >>
> >> >
> >> > You should never use signed types for a bit field. That's just
> >> > asking for a sign expansion bug.
> >>
> >> my idea was more to use unsigned int instead of u16.
> >> Personally i try to avoid this (artificial) types as much as possible,
> >
> > Obviously no one wants to go nuts with the type specifiers like the
> > e1000e people who never use "int" and only "s32". But in this case
> > u16 is more readable and more accurate.
> >
>
> Do you mind to clean up this driver with u16? or I will do it.
I resent the patch already. Hopefully, that's ok?
regards,
dan carpenter
next prev parent reply other threads:[~2013-05-31 5:45 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-29 7:02 [patch] leds: renesas-tpu: cleanup a small type issue Dan Carpenter
2013-05-29 7:21 ` walter harms
2013-05-29 7:45 ` Dan Carpenter
2013-05-29 16:59 ` Bryan Wu
2013-05-29 21:09 ` [patch v2] " Dan Carpenter
2013-05-29 17:34 ` [patch] " walter harms
2013-05-29 21:15 ` Dan Carpenter
2013-05-30 8:59 ` walter harms
2013-05-30 12:02 ` Dan Carpenter
2013-05-30 17:59 ` Bryan Wu
2013-05-30 18:01 ` Bryan Wu
2013-05-31 5:44 ` Dan Carpenter
2013-05-31 5:45 ` Dan Carpenter [this message]
2013-05-31 6:38 ` Bryan Wu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130531054541.GO23987@mwanda \
--to=dan.carpenter@oracle.com \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox