From: Felipe Balbi <balbi@ti.com>
To: Emil Goode <emilgoode@gmail.com>
Cc: balbi@ti.com, gregkh@linuxfoundation.org,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH v2] usb: musb: Fix format specifier warning
Date: Fri, 31 May 2013 21:13:58 +0000 [thread overview]
Message-ID: <20130531211358.GC11520@arwen.pp.htv.fi> (raw)
In-Reply-To: <1370033389-27131-1-git-send-email-emilgoode@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 747 bytes --]
Hi,
On Fri, May 31, 2013 at 10:49:49PM +0200, Emil Goode wrote:
> This patch fixes a format specifier warning. dma_addr_t can be either
> u32 or u64 so we should cast to the largest type and change the format
> specifier to %llx.
> The addition of urb->transfer_dma and urb->actual_length is also done a
> few lines below. I have moved this code up and pass the variable buf to
> dev_dbg.
>
> Sparse output:
> drivers/usb/musb/musb_host.c:1761:4: warning:
> format ‘%x’ expects argument of type ‘unsigned int’,
> but argument 6 has type ‘dma_addr_t’ [-Wformat]
>
> Signed-off-by: Emil Goode <emilgoode@gmail.com>
already sent this one yesterday:
http://marc.info/?l=linux-usb&m=136987256218081
--
balbi
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
prev parent reply other threads:[~2013-05-31 21:13 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-31 20:49 [PATCH v2] usb: musb: Fix format specifier warning Emil Goode
2013-05-31 21:13 ` Felipe Balbi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130531211358.GC11520@arwen.pp.htv.fi \
--to=balbi@ti.com \
--cc=emilgoode@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox