kernel-janitors.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [patch] cpqarray: info leak in ida_locked_ioctl()
@ 2013-06-03  9:25 Dan Carpenter
  2013-09-11  7:38 ` [patch -resend] " Dan Carpenter
  0 siblings, 1 reply; 3+ messages in thread
From: Dan Carpenter @ 2013-06-03  9:25 UTC (permalink / raw)
  To: Chirag Kantharia; +Cc: iss_storagedev, linux-kernel, kernel-janitors

The pciinfo struct has a two byte hole after ->dev_fn so stack
information could be leaked to the user.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

diff --git a/drivers/block/cpqarray.c b/drivers/block/cpqarray.c
index 639d26b..2b94403 100644
--- a/drivers/block/cpqarray.c
+++ b/drivers/block/cpqarray.c
@@ -1193,6 +1193,7 @@ out_passthru:
 		ida_pci_info_struct pciinfo;
 
 		if (!arg) return -EINVAL;
+		memset(&pciinfo, 0, sizeof(pciinfo));
 		pciinfo.bus = host->pci_dev->bus->number;
 		pciinfo.dev_fn = host->pci_dev->devfn;
 		pciinfo.board_id = host->board_id;

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [patch -resend] cpqarray: info leak in ida_locked_ioctl()
  2013-06-03  9:25 [patch] cpqarray: info leak in ida_locked_ioctl() Dan Carpenter
@ 2013-09-11  7:38 ` Dan Carpenter
  2013-09-11 17:23   ` Miller, Mike (OS Dev)
  0 siblings, 1 reply; 3+ messages in thread
From: Dan Carpenter @ 2013-09-11  7:38 UTC (permalink / raw)
  To: Chirag Kantharia, Andrew Morton
  Cc: iss_storagedev, linux-kernel, kernel-janitors, Moritz Muehlenhoff

The pciinfo struct has a two byte hole after ->dev_fn so stack
information could be leaked to the user.

This was assigned CVE-2013-2147.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

diff --git a/drivers/block/cpqarray.c b/drivers/block/cpqarray.c
index 639d26b..2b94403 100644
--- a/drivers/block/cpqarray.c
+++ b/drivers/block/cpqarray.c
@@ -1193,6 +1193,7 @@ out_passthru:
 		ida_pci_info_struct pciinfo;
 
 		if (!arg) return -EINVAL;
+		memset(&pciinfo, 0, sizeof(pciinfo));
 		pciinfo.bus = host->pci_dev->bus->number;
 		pciinfo.dev_fn = host->pci_dev->devfn;
 		pciinfo.board_id = host->board_id;

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* RE: [patch -resend] cpqarray: info leak in ida_locked_ioctl()
  2013-09-11  7:38 ` [patch -resend] " Dan Carpenter
@ 2013-09-11 17:23   ` Miller, Mike (OS Dev)
  0 siblings, 0 replies; 3+ messages in thread
From: Miller, Mike (OS Dev) @ 2013-09-11 17:23 UTC (permalink / raw)
  To: Dan Carpenter, Chirag Kantharia, Andrew Morton
  Cc: ISS StorageDev, linux-kernel@vger.kernel.org,
	kernel-janitors@vger.kernel.org, Moritz Muehlenhoff



-----Original Message-----
From: Dan Carpenter [mailto:dan.carpenter@oracle.com] 
Sent: Wednesday, September 11, 2013 2:38 AM
To: Chirag Kantharia; Andrew Morton
Cc: ISS StorageDev; linux-kernel@vger.kernel.org; kernel-janitors@vger.kernel.org; Moritz Muehlenhoff
Subject: [patch -resend] cpqarray: info leak in ida_locked_ioctl()

The pciinfo struct has a two byte hole after ->dev_fn so stack information could be leaked to the user.

This was assigned CVE-2013-2147.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

Acked-by: Mike Miller <mike.miller@hp.com>

diff --git a/drivers/block/cpqarray.c b/drivers/block/cpqarray.c index 639d26b..2b94403 100644
--- a/drivers/block/cpqarray.c
+++ b/drivers/block/cpqarray.c
@@ -1193,6 +1193,7 @@ out_passthru:
 		ida_pci_info_struct pciinfo;
 
 		if (!arg) return -EINVAL;
+		memset(&pciinfo, 0, sizeof(pciinfo));
 		pciinfo.bus = host->pci_dev->bus->number;
 		pciinfo.dev_fn = host->pci_dev->devfn;
 		pciinfo.board_id = host->board_id;

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2013-09-11 17:23 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-06-03  9:25 [patch] cpqarray: info leak in ida_locked_ioctl() Dan Carpenter
2013-09-11  7:38 ` [patch -resend] " Dan Carpenter
2013-09-11 17:23   ` Miller, Mike (OS Dev)

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).