Re: [patch -next] FMC: NULL dereference on allocation failure

Joe Perches
2013-06-19T16:15:04Z

On Wed, 2013-06-19 at 19:01 +0300, Dan Carpenter wrote:
> If we don't allocate "arr" then the cleanup path will dereference it and
> oops.
[]
> diff --git a/drivers/fmc/fmc-sdb.c b/drivers/fmc/fmc-sdb.c
[]
> @@ -46,16 +46,17 @@ static struct sdb_array *__fmc_scan_sdb_tree(struct fmc_device *fmc,
[]
> - arr->record = kzalloc(sizeof(arr->record[0]) * n, GFP_KERNEL);
> - arr->subtree = kzalloc(sizeof(arr->subtree[0]) * n, GFP_KERNEL);
[]
> + arr->record = kzalloc(sizeof(arr->record[0]) * n, GFP_KERNEL);
> + arr->subtree = kzalloc(sizeof(arr->subtree[0]) * n, GFP_KERNEL);

n comes from the hardware no?
Maybe make these kcalloc too.