From: Dan Carpenter <dan.carpenter@oracle.com>
To: kernel-janitors@vger.kernel.org
Subject: Re: request_region return value check
Date: Mon, 15 Jul 2013 20:06:53 +0000 [thread overview]
Message-ID: <20130715200653.GB5152@mwanda> (raw)
In-Reply-To: <20130714173056.GA50500@gmail.com>
On Mon, Jul 15, 2013 at 10:35:27PM +0530, Vivek Subbarao wrote:
> On Mon, Jul 15, 2013 at 04:20:26PM +0300, Dan Carpenter wrote:
> > On Sun, Jul 14, 2013 at 11:00:58PM +0530, Vivek Subbarao wrote:
> > > There are many places where the return value from request_region is not
> > > checked for null value. This is required right ? I am just checking
> > > before I can send patched fixing them
> >
> > Most of the time, but not always.
> >
> > Sometimes people know it will succeed. The first one I looked at
> > in drivers/acpi/acpi_processor.c the caller doesn't care if it
> > succeeds and there is a comment explaining why.
> >
> I see a lot of calls to request_region in __init calls. For example
> there is a call in netwinder-hw.c:wb977_init. Should they be checking
> for the return value ?
This is a very well defined specific hardware and they know it won't
fail or if it were to fail then the system couldn't boot anyway so
returning an error code doesn't do any good.
regards,
dan carpenter
prev parent reply other threads:[~2013-07-15 20:06 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-14 17:42 request_region return value check Vivek Subbarao
2013-07-15 13:20 ` Dan Carpenter
2013-07-15 17:17 ` Vivek Subbarao
2013-07-15 20:06 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130715200653.GB5152@mwanda \
--to=dan.carpenter@oracle.com \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox