From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dan Carpenter Date: Wed, 17 Jul 2013 12:26:14 +0000 Subject: [patch] hwmon: using wrong ARRAY_SIZE() limit Message-Id: <20130717084317.GA4851@elgon.mountain> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: kernel-janitors@vger.kernel.org We cleaned up this code to use ARRAY_SIZE() instead of just the number 4. The problem is that data->reg_temp[] has 5 elements and we actually wanted ARRAY_SIZE(data->temp) which has 4 elements. Signed-off-by: Dan Carpenter diff --git a/drivers/hwmon/nct6775.c b/drivers/hwmon/nct6775.c index f0941d7..52b6a92 100644 --- a/drivers/hwmon/nct6775.c +++ b/drivers/hwmon/nct6775.c @@ -1451,7 +1451,7 @@ static struct nct6775_data *nct6775_update_device(struct device *dev) for (i = 0; i < NUM_TEMP; i++) { if (!(data->have_temp & (1 << i))) continue; - for (j = 0; j < ARRAY_SIZE(data->reg_temp); j++) { + for (j = 0; j < ARRAY_SIZE(data->temp); j++) { if (data->reg_temp[j][i]) data->temp[j][i] = nct6775_read_temp(data, @@ -3974,7 +3974,7 @@ static int nct6775_resume(struct device *dev) if (!(data->have_temp & (1 << i))) continue; - for (j = 1; j < ARRAY_SIZE(data->reg_temp); j++) + for (j = 1; j < ARRAY_SIZE(data->temp); j++) if (data->reg_temp[j][i]) nct6775_write_temp(data, data->reg_temp[j][i], data->temp[j][i]);