* [patch v2] hwmon: (nct6775) make an array larger
@ 2013-07-18 15:01 Dan Carpenter
2013-07-18 21:26 ` Guenter Roeck
0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2013-07-18 15:01 UTC (permalink / raw)
To: kernel-janitors
Smatch complains that we have a array overflow:
drivers/hwmon/nct6775.c:1456 nct6775_update_device()
error: buffer overflow 'data->temp' 4 <= 4
Guenter Roeck says that the array should have been made larger in
7cbbd6aee6 (Add support for critical low/high temperature limits on
NCT6106). This patch does that.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
v2: the first version was wrong
diff --git a/drivers/hwmon/nct6775.c b/drivers/hwmon/nct6775.c
index f0941d7..25e2c7b 100644
--- a/drivers/hwmon/nct6775.c
+++ b/drivers/hwmon/nct6775.c
@@ -813,8 +813,8 @@ struct nct6775_data {
u8 temp_fixed_num; /* 3 or 6 */
u8 temp_type[NUM_TEMP_FIXED];
s8 temp_offset[NUM_TEMP_FIXED];
- s16 temp[4][NUM_TEMP]; /* 0=temp, 1=temp_over, 2=temp_hyst,
- * 3=temp_crit */
+ s16 temp[5][NUM_TEMP]; /* 0=temp, 1=temp_over, 2=temp_hyst,
+ * 3=temp_crit, 4=temp_lcrit */
u64 alarms;
u64 beeps;
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [patch v2] hwmon: (nct6775) make an array larger
2013-07-18 15:01 [patch v2] hwmon: (nct6775) make an array larger Dan Carpenter
@ 2013-07-18 21:26 ` Guenter Roeck
0 siblings, 0 replies; 2+ messages in thread
From: Guenter Roeck @ 2013-07-18 21:26 UTC (permalink / raw)
To: kernel-janitors
On Thu, Jul 18, 2013 at 06:01:11PM +0300, Dan Carpenter wrote:
> Smatch complains that we have a array overflow:
>
> drivers/hwmon/nct6775.c:1456 nct6775_update_device()
> error: buffer overflow 'data->temp' 4 <= 4
>
> Guenter Roeck says that the array should have been made larger in
> 7cbbd6aee6 (Add support for critical low/high temperature limits on
> NCT6106). This patch does that.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Applied. Thanks a lot for the patch.
I really need to enable smatch on my nightly builds :(
Guenter
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-07-18 21:26 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-07-18 15:01 [patch v2] hwmon: (nct6775) make an array larger Dan Carpenter
2013-07-18 21:26 ` Guenter Roeck
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).