From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dan Carpenter Date: Fri, 19 Jul 2013 09:26:03 +0000 Subject: [RFC] nilfs2: double bio_put() in nilfs_end_bio_write() Message-Id: <20130719092603.GB22147@longonot.mountain> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: kernel-janitors@vger.kernel.org I don't know if this is correct or not, but if feels like we shouldn't be calling bio_put() twice in nilfs_end_bio_write(). Also the comment is out of date. If this is correct then I can resend with a proper Signed-off-by line and everything. diff --git a/fs/nilfs2/segbuf.c b/fs/nilfs2/segbuf.c index dc9a913..a660fd7 100644 --- a/fs/nilfs2/segbuf.c +++ b/fs/nilfs2/segbuf.c @@ -346,7 +346,8 @@ static void nilfs_end_bio_write(struct bio *bio, int err) if (err = -EOPNOTSUPP) { set_bit(BIO_EOPNOTSUPP, &bio->bi_flags); bio_put(bio); - /* to be detected by submit_seg_bio() */ + /* to be detected by nilfs_segbuf_submit_bio() */ + return; } if (!uptodate)