From: Dan Carpenter <dan.carpenter@oracle.com>
To: Matthew Garrett <matthew.garrett@nebula.com>
Cc: platform-driver-x86@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: [patch v2] intel_ips: cleanup a couple error messages
Date: Mon, 22 Jul 2013 20:38:39 +0000 [thread overview]
Message-ID: <20130722203839.GA22020@elgon.mountain> (raw)
In-Reply-To: <20130719055144.GE9729@elgon.mountain>
Printing PTR_ERR(NULL) is not useful so I have updated the error
messages a little.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
v2: completely different
diff --git a/drivers/platform/x86/intel_ips.c b/drivers/platform/x86/intel_ips.c
index 18dcb58..e5c115d 100644
--- a/drivers/platform/x86/intel_ips.c
+++ b/drivers/platform/x86/intel_ips.c
@@ -1329,9 +1329,7 @@ static void ips_debugfs_init(struct ips_driver *ips)
ips->debug_root = debugfs_create_dir("ips", NULL);
if (!ips->debug_root) {
- dev_err(&ips->dev->dev,
- "failed to create debugfs entries: %ld\n",
- PTR_ERR(ips->debug_root));
+ dev_err(&ips->dev->dev, "failed to create debugfs entries\n");
return;
}
@@ -1345,8 +1343,8 @@ static void ips_debugfs_init(struct ips_driver *ips)
&ips_debugfs_ops);
if (!ent) {
dev_err(&ips->dev->dev,
- "failed to create debug file: %ld\n",
- PTR_ERR(ent));
+ "failed to create debug file: %s\n",
+ node->name);
goto err_cleanup;
}
}
prev parent reply other threads:[~2013-07-22 20:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-19 5:51 [patch] intel_ips: fix error handling for debugfs_create_dir() Dan Carpenter
2013-07-21 14:56 ` Dan Carpenter
2013-07-22 20:38 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130722203839.GA22020@elgon.mountain \
--to=dan.carpenter@oracle.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=matthew.garrett@nebula.com \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox