From mboxrd@z Thu Jan 1 00:00:00 1970 From: Greg Kroah-Hartman Date: Tue, 23 Jul 2013 04:35:10 +0000 Subject: Re: [patch v2] virtio: console: cleanup an error message Message-Id: <20130723043510.GA26883@kroah.com> List-Id: References: <201307191228.41794.arnd@arndb.de> <20130722204100.GB22020@elgon.mountain> In-Reply-To: <20130722204100.GB22020@elgon.mountain> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Dan Carpenter Cc: Amit Shah , kernel-janitors@vger.kernel.org, Arnd Bergmann , virtualization@lists.linux-foundation.org On Mon, Jul 22, 2013 at 11:41:00PM +0300, Dan Carpenter wrote: > The PTR_ERR(NULL) here is not useful. > > Signed-off-by: Dan Carpenter > --- > v2: completely different > > diff --git a/drivers/char/virtio_console.c b/drivers/char/virtio_console.c > index 1b456fe..4cf46d8 100644 > --- a/drivers/char/virtio_console.c > +++ b/drivers/char/virtio_console.c Rusty handles virtio stuff, please cc: him on these. thanks, greg k-h