From: Dan Carpenter <dan.carpenter@oracle.com>
To: kernel-janitors@vger.kernel.org
Subject: Re: [PATCH 1/9] Staging:wlan-ng:cfg80211.c,p80211conv.h,p80211metastruct.h,p80211netdev.h:
Date: Wed, 24 Jul 2013 16:01:23 +0000 [thread overview]
Message-ID: <20130724160123.GW5585@mwanda> (raw)
In-Reply-To: <1374673972-10041-1-git-send-email-kumargauravgupta3@gmail.com>
On Wed, Jul 24, 2013 at 08:55:34PM +0530, Kumar Gaurav wrote:
> Thanks for your valuable suggestions.
> Sorry to ask stupid questions but still i do have before i can
> correct fix for above. Please spare me and answer them
>
> 1. Is it correct to change variable names for long variables
> in code without notifying the author of the code?
Sending to kernel-janitors is just practice. Next time send it to
the people from ./scripts/get_maintainer.pl (You need git for this
to work correctly really).
But I help maintain staging/ so I know what patches are likely to be
applied there.
> 2. How would i align long statement in multiple lines so that
> they remain readable (this i'll google now, but still adding)
- bss = cfg80211_inform_bss(wiphy,
- ieee80211_get_channel(wiphy, ieee80211_dsss_chan_to_freq(msg2.dschannel.data)),
+ freq = ieee80211_dsss_chan_to_freq(msg2.dschannel.data);
+ chan = ieee80211_get_channel(wiphy, freq);
+ bss = cfg80211_inform_bss(wiphy, chan, ...
etc.
regards,
dan carpenter
next prev parent reply other threads:[~2013-07-24 16:01 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-24 14:04 [PATCH 1/9] Staging:wlan-ng:cfg80211.c,p80211conv.h,p80211metastruct.h,p80211netdev.h: Fixed code st Kumar Gaurav
2013-07-24 15:04 ` [PATCH 1/9] Staging:wlan-ng:cfg80211.c,p80211conv.h,p80211metastruct.h,p80211netdev.h: Dan Carpenter
2013-07-24 15:37 ` [PATCH 1/9] Staging:wlan-ng:cfg80211.c,p80211conv.h,p80211metastruct.h,p80211netdev.h: Fixed cod Kumar Gaurav
2013-07-24 16:01 ` Dan Carpenter [this message]
2013-07-24 16:10 ` [PATCH 1/9] Staging:wlan-ng:cfg80211.c,p80211conv.h,p80211metastruct.h,p80211netdev.h: Dan Carpenter
2013-07-24 16:19 ` [PATCH 1/9] Staging:wlan-ng:cfg80211.c,p80211conv.h,p80211metastruct.h,p80211netdev.h: Fixed cod Kumar Gaurav
2013-07-25 14:23 ` [PATCH 1/9] Staging:wlan-ng:cfg80211.c,p80211conv.h,p80211metastruct.h,p80211netdev.h: Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130724160123.GW5585@mwanda \
--to=dan.carpenter@oracle.com \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).