public inbox for kernel-janitors@vger.kernel.org
 help / color / mirror / Atom feed
From: Emil Goode <emilgoode@gmail.com>
To: kernel-janitors@vger.kernel.org
Subject: Re: [PATCH 1/2] staging: lustre: Fix non-ANSI sparse warnings
Date: Sat, 27 Jul 2013 19:53:34 +0000	[thread overview]
Message-ID: <20130727195334.GB11837@debian> (raw)
In-Reply-To: <1374950412-15973-1-git-send-email-emilgoode@gmail.com>

Hi Andi,

I ususally put the warnings in the change log but when it's a long list
I prefer leaving them out. If you would like the full list I can resend.
Perhaps I should change the commit message to:
This patch fixes a lot of non-ANSI sparse warnings by adding void to
parameterless functions.

Best regards,

Emil

On Sat, Jul 27, 2013 at 09:20:45PM +0200, Andi Shyti wrote:
> > This patch fixes a lot of non-ANSI sparse warnings.
> 
> would be better if you sepcify which non-ANSI sparse warnings.
> 
> In this patch you are doing only one type of change that is to
> add a void parameter to functions which don't get one.
> 
> Andi
> 
> > Signed-off-by: Emil Goode <emilgoode@gmail.com>

  parent reply	other threads:[~2013-07-27 19:53 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-27 18:40 [PATCH 1/2] staging: lustre: Fix non-ANSI sparse warnings Emil Goode
2013-07-27 19:20 ` Andi Shyti
2013-07-27 19:53 ` Emil Goode [this message]
2013-07-27 21:32 ` Andi Shyti

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130727195334.GB11837@debian \
    --to=emilgoode@gmail.com \
    --cc=kernel-janitors@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox