From: Dan Carpenter <dan.carpenter@oracle.com>
To: kernel-janitors@vger.kernel.org
Subject: Re: [PATCH 1/3] spi/spi-atmel: Fix format specifier warnings
Date: Wed, 31 Jul 2013 08:23:24 +0000 [thread overview]
Message-ID: <20130731082324.GG5002@mwanda> (raw)
In-Reply-To: <1375205737-3468-1-git-send-email-emilgoode@gmail.com>
On Wed, Jul 31, 2013 at 10:16:59AM +0200, walter harms wrote:
>
>
> Am 30.07.2013 19:35, schrieb Emil Goode:
> > This patch fixes the following sparse warnings.
> > dma_addr_t can be either u32 or u64 so we should cast to the
> > largest type and use the format specifier %llx.
> >
> > drivers/spi/spi-atmel.c: In function ‘atmel_spi_next_xfer_dma_submit’:
> > drivers/spi/spi-atmel.c:631:2: warning:
> > format ‘%x’ expects argument of type ‘unsigned int’,
> > but argument 7 has type ‘dma_addr_t’ [-Wformat]
>
> maybe a %p is better here?
>
No, that doesn't work for dma_addr_t.
regards,
dan carpenter
next prev parent reply other threads:[~2013-07-31 8:23 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-30 17:35 [PATCH 1/3] spi/spi-atmel: Fix format specifier warnings Emil Goode
2013-07-31 8:16 ` walter harms
2013-07-31 8:23 ` Dan Carpenter [this message]
2013-07-31 16:55 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130731082324.GG5002@mwanda \
--to=dan.carpenter@oracle.com \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox