Re: Updated FarSync driver

Dan Carpenter
2013-07-31T14:50:17Z

On Wed, Jul 31, 2013 at 02:55:50PM +0100, Kevin Curtis wrote:
> Hi Dan,
> I am fixing the errors and warning reported by checkpatch. I have quite a few of these:
>
> ERROR: do not initialise globals to 0 or NULL
> #90: FILE: drivers/net/wan/farsync.c:83:
> +int fst_excluded_cards = 0;
>
> Is this because when the module is loaded the globals are
> guaranteed to be zero'd already, or is the module init is expected
> to initialise them?
>

In C globals are always initialized to zero at the start.

I think there was a reason to prefer one way over the other with
older versions of GCC but now it's just a style preference or
something.