From: Dan Carpenter <dan.carpenter@oracle.com>
To: kernel-janitors@vger.kernel.org
Subject: re: pktcdvd: add struct pktcdvd_device.name to pr_err logging where possible
Date: Thu, 01 Aug 2013 15:44:26 +0000 [thread overview]
Message-ID: <20130801154426.GA5198@elgon.mountain> (raw)
Hello Joe Perches,
This is a semi-automatic email about new static checker warnings.
The patch b5a0e979a657: "pktcdvd: add struct pktcdvd_device.name to
pr_err logging where possible" from Aug 1, 2013, leads to the
following Smatch complaint:
drivers/block/pktcdvd.c:2363 pkt_make_request()
error: we previously assumed 'pd' could be null (see line 2362)
drivers/block/pktcdvd.c
2361 pd = q->queuedata;
2362 if (!pd) {
^^^
Old check.
2363 pkt_err(pd, "%s incorrect request queue\n",
^^^
New dereference.
2364 bdevname(bio->bi_bdev, b));
2365 goto end_io;
regards,
dan carpenter
reply other threads:[~2013-08-01 15:44 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130801154426.GA5198@elgon.mountain \
--to=dan.carpenter@oracle.com \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox