From: Dan Carpenter <dan.carpenter@oracle.com>
To: kernel-janitors@vger.kernel.org
Subject: re: pktcdvd: add struct pktcdvd_device * to pkt_dbg
Date: Thu, 01 Aug 2013 15:44:52 +0000 [thread overview]
Message-ID: <20130801154452.GB5198@elgon.mountain> (raw)
Hello Joe Perches,
This is a semi-automatic email about new static checker warnings.
The patch 3567318a63ff: "pktcdvd: add struct pktcdvd_device * to
pkt_dbg" from Aug 1, 2013, leads to the following Smatch complaint:
drivers/block/pktcdvd.c:2844 pkt_remove_dev()
error: we previously assumed 'pd' could be null (see line 2840)
drivers/block/pktcdvd.c
2839 pd = pkt_devs[idx];
2840 if (pd && (pd->pkt_dev = pkt_dev))
^^
Old check.
2841 break;
2842 }
2843 if (idx = MAX_WRITERS) {
2844 pkt_dbg(1, pd, "dev not setup\n");
^^
New dereference.
2845 ret = -ENXIO;
2846 goto out;
regards,
dan carpenter
next reply other threads:[~2013-08-01 15:44 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-01 15:44 Dan Carpenter [this message]
2013-08-01 16:32 ` pktcdvd: add struct pktcdvd_device * to pkt_dbg Joe Perches
2013-08-02 20:10 ` [PATCH] pktcdvd: Fix defective misuses of pkt_<level> Joe Perches
2013-08-06 20:21 ` Andrew Morton
2013-08-06 23:58 ` Jiri Kosina
2013-08-26 10:58 ` Jiri Kosina
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130801154452.GB5198@elgon.mountain \
--to=dan.carpenter@oracle.com \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox