From: Dan Carpenter <dan.carpenter@oracle.com>
To: kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] Staging: winbond: wb35reg: fixed some line over 80 characters
Date: Fri, 02 Aug 2013 10:33:19 +0000 [thread overview]
Message-ID: <20130802103319.GC5051@mwanda> (raw)
In-Reply-To: <1375386221-3726-1-git-send-email-ikerpedrosam@gmail.com>
Looks ok. Send it to the ./scripts/get_maintainer.pl people.
On Thu, Aug 01, 2013 at 09:43:41PM +0200, Iker Pedrosa wrote:
> @@ -139,9 +141,10 @@ unsigned char Wb35Reg_WriteSync(struct hw_data *pHwData, u16 RegisterNo, u32 Reg
> /* Sync IoCallDriver */
> reg->EP0vm_state = VM_RUNNING;
> ret = usb_control_msg(pHwData->udev,
> - usb_sndctrlpipe(pHwData->udev, 0),
> - 0x03, USB_TYPE_VENDOR | USB_RECIP_DEVICE | USB_DIR_OUT,
> - 0x0, RegisterNo, &RegisterValue, 4, HZ * 100);
> + usb_sndctrlpipe(pHwData->udev, 0),
> + 0x03,
The "0x03," will fit on the line before:
+ usb_sndctrlpipe(pHwData->udev, 0), 0x03,
> + USB_TYPE_VENDOR | USB_RECIP_DEVICE | USB_DIR_OUT,
> + 0x0, RegisterNo, &RegisterValue, 4, HZ * 100);
> reg->EP0vm_state = VM_STOP;
> reg->SyncIoPause = 0;
There is a similar thing below as well.
regards,
dan carpenter
prev parent reply other threads:[~2013-08-02 10:33 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-01 19:43 [PATCH] Staging: winbond: wb35reg: fixed some line over 80 characters Iker Pedrosa
2013-08-02 10:33 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130802103319.GC5051@mwanda \
--to=dan.carpenter@oracle.com \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox