From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Date: Fri, 09 Aug 2013 16:27:53 +0000 Subject: Re: [Intel-gfx] [patch v2] drm/i915: fix a limit check in hsw_compute_wm_results() Message-Id: <20130809162753.GA31670@phenom.ffwll.local> List-Id: References: <20130809095826.GA4313@cantiga.alporthouse.com> <20130809100731.GA31727@elgon.mountain> <20130809102933.GD5004@intel.com> In-Reply-To: <20130809102933.GD5004@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable To: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Cc: Dan Carpenter , Daniel Vetter , Chris Wilson , David Airlie , intel-gfx@lists.freedesktop.org, kernel-janitors@vger.kernel.org, dri-devel@lists.freedesktop.org On Fri, Aug 09, 2013 at 01:29:33PM +0300, Ville Syrj=E4l=E4 wrote: > On Fri, Aug 09, 2013 at 01:07:31PM +0300, Dan Carpenter wrote: > > The '!' here was not intended. Since '!' has higher precedence than > > compare, it means the check is never true. > >=20 > > Signed-off-by: Dan Carpenter >=20 > Reviewed-by: Ville Syrj=E4l=E4 >=20 > The culprit for Daniel: >=20 > commit 71fff20ff1bb790f4defe0c880e028581ffab420 > Author: Ville Syrj=E4l=E4 > Date: Tue Aug 6 22:24:03 2013 +0300 >=20 > drm/i915: Kill fbc_enable from hsw_lp_wm_results Queued for -next, thanks for the patch. -Daniel >=20 > > --- > > v2: My first patch was wrong. > >=20 > > diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/int= el_pm.c > > index 96234c6..0f5eb21 100644 > > --- a/drivers/gpu/drm/i915/intel_pm.c > > +++ b/drivers/gpu/drm/i915/intel_pm.c > > @@ -2685,7 +2685,7 @@ static void hsw_compute_wm_results(struct drm_dev= ice *dev, > > * a WM level. */ > > results->enable_fbc_wm =3D true; > > for (level =3D 1; level <=3D max_level; level++) { > > - if (!lp_results[level - 1].fbc_val > lp_maximums->fbc) { > > + if (lp_results[level - 1].fbc_val > lp_maximums->fbc) { > > results->enable_fbc_wm =3D false; > > lp_results[level - 1].fbc_val =3D 0; > > } > > _______________________________________________ > > Intel-gfx mailing list > > Intel-gfx@lists.freedesktop.org > > http://lists.freedesktop.org/mailman/listinfo/intel-gfx >=20 > --=20 > Ville Syrj=E4l=E4 > Intel OTC --=20 Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" = in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html