From mboxrd@z Thu Jan 1 00:00:00 1970 From: Vinod Koul Date: Wed, 14 Aug 2013 09:34:00 +0000 Subject: Re: [PATCH 7/29] dma: mmp: simplify use of devm_ioremap_resource Message-Id: <20130814092200.GN32147@intel.com> List-Id: References: <1376471493-22215-1-git-send-email-Julia.Lawall@lip6.fr> <1376471493-22215-8-git-send-email-Julia.Lawall@lip6.fr> In-Reply-To: <1376471493-22215-8-git-send-email-Julia.Lawall@lip6.fr> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Julia Lawall Cc: kernel-janitors@vger.kernel.org, Dan Williams , linux-kernel@vger.kernel.org On Wed, Aug 14, 2013 at 11:11:11AM +0200, Julia Lawall wrote: > From: Julia Lawall > > Remove unneeded error handling on the result of a call to > platform_get_resource when the value is passed to devm_ioremap_resource. > > A simplified version of the semantic patch that makes this change is as > follows: (http://coccinelle.lip6.fr/) > > // > @@ > expression pdev,res,n,e,e1; > expression ret != 0; > identifier l; > @@ > > - res = platform_get_resource(pdev, IORESOURCE_MEM, n); > ... when != res > - if (res = NULL) { ... \(goto l;\|return ret;\) } > ... when != res > + res = platform_get_resource(pdev, IORESOURCE_MEM, n); > e = devm_ioremap_resource(e1, res); > // > > Signed-off-by: Julia Lawall Applied, thanks ~Vinod