public inbox for kernel-janitors@vger.kernel.org
 help / color / mirror / Atom feed
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Tejun Heo <tj@kernel.org>
Cc: Grant Likely <grant.likely@linaro.org>,
	Rob Herring <rob.herring@calxeda.com>,
	linux-ide@vger.kernel.org, devicetree@vger.kernel.org,
	kernel-janitors@vger.kernel.org
Subject: [patch] sata, highbank: clear whole array in highbank_initialize_phys()
Date: Fri, 16 Aug 2013 07:33:36 +0000	[thread overview]
Message-ID: <20130816073336.GA9881@elgon.mountain> (raw)

The problem is that we use "CPHY_PORT_COUNT" as the size of the
tx_atten[] array, but that's the number of elements and not the number
of bytes.  I've changed it to use sizeof(tx_atten) instead.

The other two calls to memset() were correct but I changed them as well
for consistency.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
We don't clear the cphy_base[] array.  I don't know the code well enough
to say if that is intentional or not.

diff --git a/drivers/ata/sata_highbank.c b/drivers/ata/sata_highbank.c
index 7f5e5d9..6abe2d5 100644
--- a/drivers/ata/sata_highbank.c
+++ b/drivers/ata/sata_highbank.c
@@ -347,9 +347,9 @@ static int highbank_initialize_phys(struct device *dev, void __iomem *addr)
 	struct device_node *phy_nodes[CPHY_PHY_COUNT];
 	u32 tx_atten[CPHY_PORT_COUNT];
 
-	memset(port_data, 0, sizeof(struct phy_lane_info) * CPHY_PORT_COUNT);
-	memset(phy_nodes, 0, sizeof(struct device_node*) * CPHY_PHY_COUNT);
-	memset(tx_atten, 0xff, CPHY_PORT_COUNT);
+	memset(port_data, 0, sizeof(port_data));
+	memset(phy_nodes, 0, sizeof(phy_nodes));
+	memset(tx_atten, 0xff, sizeof(tx_atten));
 
 	do {
 		u32 tmp;

             reply	other threads:[~2013-08-16  7:33 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-16  7:33 Dan Carpenter [this message]
2013-08-16 16:53 ` [patch] sata, highbank: clear whole array in highbank_initialize_phys() Tejun Heo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130816073336.GA9881@elgon.mountain \
    --to=dan.carpenter@oracle.com \
    --cc=devicetree@vger.kernel.org \
    --cc=grant.likely@linaro.org \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-ide@vger.kernel.org \
    --cc=rob.herring@calxeda.com \
    --cc=tj@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox