From: Sarah Sharp <sarah.a.sharp@linux.intel.com>
To: kernel-janitors@vger.kernel.org
Subject: Re: [PATCH 5/6] for fixing xhci_readl call in xhci_hub.c after removing xhci_hcd from function defin
Date: Mon, 19 Aug 2013 19:55:26 +0000 [thread overview]
Message-ID: <20130819195526.GA8592@xanatos> (raw)
In-Reply-To: <20130816192434.GG7975@xanatos>
On Sat, Aug 17, 2013 at 07:08:15PM +0300, Dan Carpenter wrote:
> On Fri, Aug 16, 2013 at 12:24:34PM -0700, Sarah Sharp wrote:
> > In general, please keep the short descriptions of your patches (which
> > turn into the subject lines of your mails) limited to around 55
> > characters.
>
> 55 is a very austere limit.
That's the limit before git-format patch starts chopping things off in
the generated file name, and it's the limit when vim git commit syntax
highlighting stops highlighting the short description.
> I've been telling people 72 character the same as email.
> `git citool` has a fixed width of 75 characters so that's what I
> normally use in practice.
But hey, 72 is a fine limit too. I'll start telling people that. :)
Sarah Sharp
prev parent reply other threads:[~2013-08-19 19:55 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-16 19:24 [PATCH 5/6] for fixing xhci_readl call in xhci_hub.c after removing xhci_hcd from function defin Sarah Sharp
2013-08-17 10:55 ` Dan Carpenter
2013-08-17 16:08 ` Dan Carpenter
2013-08-18 5:49 ` Julia Lawall
2013-08-19 19:55 ` Sarah Sharp [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130819195526.GA8592@xanatos \
--to=sarah.a.sharp@linux.intel.com \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox