From: David Miller <davem@davemloft.net>
To: dan.carpenter@oracle.com
Cc: nicolas.dichtel@6wind.com, kuznet@ms2.inr.ac.ru,
eric.dumazet@gmail.com, jmorris@namei.org,
yoshfuji@linux-ipv6.org, kaber@trash.net, netdev@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [patch -next v2] ipip: dereferencing an ERR_PTR in ip_tunnel_init_net()
Date: Wed, 21 Aug 2013 06:33:01 +0000 [thread overview]
Message-ID: <20130820.233301.985050199020241179.davem@davemloft.net> (raw)
In-Reply-To: <20130819222307.GA3622@elgon.mountain>
From: Dan Carpenter <dan.carpenter@oracle.com>
Date: Tue, 20 Aug 2013 01:23:07 +0300
> The __ip_tunnel_create() function returns an ERR_PTR on error so we need
> to check for that before dereferencing. This bug was added in commit
> 6c742e714d8c2 ("ipip: add x-netns support").
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> ---
> v2: Eric Dumazet said v1 patch looked racy and suggested the v2 fix.
>
This doesn't apply cleanly, you'll need to respin it.
next prev parent reply other threads:[~2013-08-21 6:33 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-19 7:05 [patch -next] ipip: dereferencing an ERR_PTR in ip_tunnel_init_net() Dan Carpenter
2013-08-19 7:33 ` Nicolas Dichtel
2013-08-19 12:58 ` Eric Dumazet
2013-08-19 13:49 ` Dan Carpenter
2013-08-19 22:23 ` [patch -next v2] " Dan Carpenter
2013-08-21 6:33 ` David Miller [this message]
2013-08-23 8:15 ` [patch -next] ipip: potential race " Dan Carpenter
2013-08-25 22:40 ` David Miller
2013-08-20 22:08 ` [patch -next] ipip: dereferencing an ERR_PTR " David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130820.233301.985050199020241179.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=dan.carpenter@oracle.com \
--cc=eric.dumazet@gmail.com \
--cc=jmorris@namei.org \
--cc=kaber@trash.net \
--cc=kernel-janitors@vger.kernel.org \
--cc=kuznet@ms2.inr.ac.ru \
--cc=netdev@vger.kernel.org \
--cc=nicolas.dichtel@6wind.com \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox