From mboxrd@z Thu Jan  1 00:00:00 1970
From: Dan Carpenter <dan.carpenter@oracle.com>
Date: Tue, 20 Aug 2013 09:00:14 +0000
Subject: [patch] staging: comedi: pcmuio: remove an unneeded check
Message-Id: <20130820090013.GC20170@elgon.mountain>
List-Id: <kernel-janitors.vger.kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: kernel-janitors@vger.kernel.org

"devpriv" is non-NULL at this point.  We dereference it earlier in the
function and the inconsistent checking upsets static checkers.  We don't
need to check "devpriv->sprivs" because kfree() accepts NULL pointers.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

diff --git a/drivers/staging/comedi/drivers/pcmuio.c b/drivers/staging/comedi/drivers/pcmuio.c
index f942455..a779062 100644
--- a/drivers/staging/comedi/drivers/pcmuio.c
+++ b/drivers/staging/comedi/drivers/pcmuio.c
@@ -676,8 +676,7 @@ static void pcmuio_detach(struct comedi_device *dev)
 		if (devpriv->asics[i].irq)
 			free_irq(devpriv->asics[i].irq, dev);
 	}
-	if (devpriv && devpriv->sprivs)
-		kfree(devpriv->sprivs);
+	kfree(devpriv->sprivs);
 	comedi_legacy_detach(dev);
 }