public inbox for kernel-janitors@vger.kernel.org
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@linux-foundation.org>
To: Joe Perches <joe@perches.com>
Cc: Rob Landley <rob@landley.net>, Jiri Kosina <jkosina@suse.cz>,
	LKML <linux-kernel@vger.kernel.org>,
	kernel-janitors <kernel-janitors@vger.kernel.org>
Subject: Re: rfc: trivial patches and slow deaths?
Date: Tue, 20 Aug 2013 22:24:56 +0000	[thread overview]
Message-ID: <20130820152456.c12dd8f543e2735b6952ae13@linux-foundation.org> (raw)
In-Reply-To: <1377036678.2016.88.camel@joe-AO722>

On Tue, 20 Aug 2013 15:11:18 -0700 Joe Perches <joe@perches.com> wrote:

> Andrew?  Do you want to handle patches for defects that
> are both obvious _and_ trivial?

I look at everything!  If I like it and see that Jiri was cc'ed I try
to remember to cc him on the commit.

> > If it's trivial it's not time critical. If it's time critical it's not  
> > trivial.
> 
> We disagree on the definition of trivial.
> Trivial can also mean simple and immediately evident.

I find that I often remove "trivial" from changelogs and titles.  Patches
which are marked thus are often non-trivial and merit a bit of thought.


For example, I somewhat disagree that even
https://patchwork.kernel.org/patch/2833648/ was trivial.  It changes
the format of kernel logs and might have implications for people who
are parsing those logs.  Unlikely, but one needs to read each and every
conversion and decide on the risk factor.



  reply	other threads:[~2013-08-20 22:24 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-19 20:27 rfc: trivial patches and slow deaths? Joe Perches
2013-08-19 20:34 ` Jiri Kosina
2013-08-19 21:10   ` Joe Perches
2013-08-19 21:22     ` Jiri Kosina
2013-08-19 21:27       ` Joe Perches
2013-08-20 20:02         ` Rob Landley
2013-08-20 20:14           ` Joe Perches
2013-08-20 21:49             ` Rob Landley
2013-08-20 22:11               ` Joe Perches
2013-08-20 22:24                 ` Andrew Morton [this message]
2013-08-20 22:49                   ` Joe Perches
2013-08-21  0:10 ` Rob Landley
2013-08-21  0:22   ` Joe Perches
2013-08-21  1:36     ` Rob Landley
2013-08-21  4:10       ` Joe Perches

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130820152456.c12dd8f543e2735b6952ae13@linux-foundation.org \
    --to=akpm@linux-foundation.org \
    --cc=jkosina@suse.cz \
    --cc=joe@perches.com \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rob@landley.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox