From: Will Deacon <will.deacon@arm.com>
To: linux-arm-kernel@lists.infradead.org
Subject: Re: [patch 1/2] iommu/arm-smmu: fix a signedness bug
Date: Wed, 21 Aug 2013 10:32:52 +0000 [thread overview]
Message-ID: <20130821103252.GC16380@mudshark.cambridge.arm.com> (raw)
In-Reply-To: <20130821083329.GF5240@elgon.mountain>
Hi Dan,
On Wed, Aug 21, 2013 at 09:33:30AM +0100, Dan Carpenter wrote:
> Unsigned char is never equal to -1.
D'oh! Thanks for the patches.
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> ---
> I can't compile this code.
I've compiled and tested both of them with an AArch32 MMU-500 model and they
work fine. I'll send this lot in Joerg's direction with the other patches I
currently have queued.
Cheers,
Will
prev parent reply other threads:[~2013-08-21 10:32 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-21 8:33 [patch 1/2] iommu/arm-smmu: fix a signedness bug Dan Carpenter
2013-08-21 10:32 ` Will Deacon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130821103252.GC16380@mudshark.cambridge.arm.com \
--to=will.deacon@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox