From mboxrd@z Thu Jan  1 00:00:00 1970
From: Sagar Padhye <sgr.m.pdy@gmail.com>
Date: Thu, 03 Oct 2013 06:46:40 +0000
Subject: Re: [PATCH] FIXED sparse warning : drivers/cpuidle/cpuidle.c:27:1: warning: symbol 'cpuidle_dev' was
Message-Id: <20131003063439.GA31795@gmail.com>
List-Id: <kernel-janitors.vger.kernel.org>
References: <1380739624-17257-1-git-send-email-sgr.m.pdy@gmail.com>
	<20131002192423.GX6192@mwanda>
In-Reply-To: <20131002192423.GX6192@mwanda>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: kernelnewbies@lists.kernelnewbies.org

> > I checked that cpuidle_devices is only being used in cpuidle.c - hence
> > thought that it can be made static and be removed from header.
> 
> "cpuidle_devices" is actually used in drivers/cpuidle/coupled.c as well
> so this breaks the build.

Darn! I forgot 'clean build' part. sorry.
 
> Even for "cpuidle_dev" the patch isn't right.  It doesn't fix the
> warning, for me.  The DEFINE_PER_CPU() macro defines several variables
> actually.  Per CPU variables are a bit complicated and they have to have
> globally unique names.  So just ignore the Sparse warning for per CPU
> variables.
> 

Ok, let me look at my sparse log once again, will pick some other problem (any suggestions?)

> There are several other "process" problems with the patch submission.
> 
> 1) Incorrect subject.  It should be:
> 	[PATCH] cpuidle: make a variable static
> 
>    This is based on `git log --oneline drivers/cpuidle/cpuidle.c`
>    output.
> 
> 2) No blank line between subject and body of commit message.
> 3) Line wrap the body of the email at 72 characters.
> 4) No Signed-off-by line.
> 

Ok, will keep this in mind

Thanks and Regards,
Sagar