From: Lee Jones <lee.jones@linaro.org>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: David Brown <davidb@codeaurora.org>,
Abhijeet Dharmapurikar <adharmap@codeaurora.org>,
Daniel Walker <dwalker@fifo99.com>,
Bryan Huntsman <bryanh@codeaurora.org>,
Samuel Ortiz <sameo@linux.intel.com>,
linux-arm-msm@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [patch] mfd: pm8921: potential NULL dereference in pm8921_remove()
Date: Thu, 07 Nov 2013 10:06:09 +0000 [thread overview]
Message-ID: <20131107100609.GL30901@lee--X1> (raw)
In-Reply-To: <20131107080420.GP21844@elgon.mountain>
Just a thought. If you use `git format-patch` you don't have to
hand-craft the [PATCH] part of the subject line.
> We assume that "pmic" could be NULL and then dereference it two lines
> later. I fix this by moving the dereference inside the NULL check.
>
> Fixes: c013f0a56c56 ('mfd: Add pm8xxx irq support')
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Patch applied thanks.
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2013-11-07 10:06 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-07 8:04 [patch] mfd: pm8921: potential NULL dereference in pm8921_remove() Dan Carpenter
2013-11-07 10:06 ` Lee Jones [this message]
2013-11-07 10:50 ` Dan Carpenter
2013-11-07 11:22 ` Lee Jones
2013-11-08 8:48 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131107100609.GL30901@lee--X1 \
--to=lee.jones@linaro.org \
--cc=adharmap@codeaurora.org \
--cc=bryanh@codeaurora.org \
--cc=dan.carpenter@oracle.com \
--cc=davidb@codeaurora.org \
--cc=dwalker@fifo99.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=sameo@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox