public inbox for kernel-janitors@vger.kernel.org
 help / color / mirror / Atom feed
From: Dan Carpenter <dan.carpenter@oracle.com>
To: kernel-janitors@vger.kernel.org
Subject: re: gma500: initial medfield merge
Date: Fri, 08 Nov 2013 10:05:21 +0000	[thread overview]
Message-ID: <20131108100521.GU27977@elgon.mountain> (raw)

Hello Kirill A. Shutemov,

This is a semi-automatic email about new static checker warnings.

The patch 026abc333205: "gma500: initial medfield merge" from Mar 8, 
2012, leads to the following Smatch complaint:

drivers/gpu/drm/gma500/mdfld_dsi_pkg_sender.c:541 __read_panel_data()
	 warn: variable dereferenced before check 'sender' (see line 536)

drivers/gpu/drm/gma500/mdfld_dsi_pkg_sender.c
   535		unsigned long flags;
   536		struct drm_device *dev = sender->dev;
                                         ^^^^^^^^^^^
Dereference.

   537		int i;
   538		u32 gen_data_reg;
   539		int retry = MDFLD_DSI_READ_MAX_COUNT;
   540	
   541		if (!sender || !data_out || !len_out) {
                    ^^^^^^^
Check.

   542			DRM_ERROR("Invalid parameters\n");
   543			return -EINVAL;

regards,
dan carpenter

                 reply	other threads:[~2013-11-08 10:05 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20131108100521.GU27977@elgon.mountain \
    --to=dan.carpenter@oracle.com \
    --cc=kernel-janitors@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox