From: Dan Carpenter <dan.carpenter@oracle.com>
To: kernel-janitors@vger.kernel.org
Subject: re: Squashfs: Refactor decompressor interface and code
Date: Mon, 11 Nov 2013 15:42:25 +0000 [thread overview]
Message-ID: <20131111154225.GA4779@elgon.mountain> (raw)
Hello Phillip Lougher,
The patch ac379b0dec4b: "Squashfs: Refactor decompressor interface
and code" from Oct 7, 2013, leads to the following
static checker warning: "fs/squashfs/decompressor.c:138
squashfs_decompressor_setup()
warn: 'comp_opts' was already freed."
fs/squashfs/decompressor.c
128 void *squashfs_decompressor_setup(struct super_block *sb, unsigned short flags)
129 {
130 struct squashfs_sb_info *msblk = sb->s_fs_info;
131 void *stream, *comp_opts = get_comp_opts(sb, flags);
132
133 if (IS_ERR(comp_opts))
134 return comp_opts;
135
136 stream = squashfs_decompressor_create(msblk, comp_opts);
137 if (IS_ERR(stream))
138 kfree(comp_opts);
The _single version of squashfs_decompressor_create() frees comp_opts
but the _multi version doesn't. I'm not sure what the right thing to do
is here.
139
140 return stream;
141 }
regards,
dan carpenter
reply other threads:[~2013-11-11 15:42 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131111154225.GA4779@elgon.mountain \
--to=dan.carpenter@oracle.com \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox