From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dan Carpenter Date: Fri, 06 Dec 2013 12:58:24 +0000 Subject: [patch] spi: bcm63xx-hsspi: checking for ERR_PTR instead of NULL Message-Id: <20131206125823.GA32369@elgon.mountain> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Mark Brown , Jonas Gorski Cc: linux-spi@vger.kernel.org, kernel-janitors@vger.kernel.org devm_request_and_ioremap() returns NULL on error, it doesn't return an ERR_PTR(). Fixes: 142168eba9dc ('spi: bcm63xx-hsspi: add bcm63xx HSSPI driver') Signed-off-by: Dan Carpenter diff --git a/drivers/spi/spi-bcm63xx-hsspi.c b/drivers/spi/spi-bcm63xx-hsspi.c index bc8d848d33b7..da9f85d55c81 100644 --- a/drivers/spi/spi-bcm63xx-hsspi.c +++ b/drivers/spi/spi-bcm63xx-hsspi.c @@ -339,8 +339,8 @@ static int bcm63xx_hsspi_probe(struct platform_device *pdev) res_mem = platform_get_resource(pdev, IORESOURCE_MEM, 0); regs = devm_request_and_ioremap(dev, res_mem); - if (IS_ERR(regs)) - return PTR_ERR(regs); + if (!regs) + return -EADDRNOTAVAIL; clk = clk_get(dev, "hsspi");