From: Mark Brown <broonie@kernel.org>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Jonas Gorski <jogo@openwrt.org>,
linux-spi@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [patch v2] spi: bcm63xx-hsspi: checking for ERR_PTR instead of NULL
Date: Mon, 09 Dec 2013 17:24:40 +0000 [thread overview]
Message-ID: <20131209172440.GA29268@sirena.org.uk> (raw)
In-Reply-To: <20131206141212.GA956@elgon.mountain>
[-- Attachment #1: Type: text/plain, Size: 269 bytes --]
On Fri, Dec 06, 2013 at 05:12:13PM +0300, Dan Carpenter wrote:
> devm_request_and_ioremap() returns NULL on error, it doesn't return an
> ERR_PTR(). This patch fixes it by switching to devm_ioremap_resource()
> which is the prefered function anyway.
Applied, thanks.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
prev parent reply other threads:[~2013-12-09 17:24 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-06 12:58 [patch] spi: bcm63xx-hsspi: checking for ERR_PTR instead of NULL Dan Carpenter
[not found] ` <20131206125823.GA32369-mgFCXtclrQlZLf2FXnZxJA@public.gmane.org>
2013-12-06 13:08 ` Jonas Gorski
2013-12-06 13:34 ` Dan Carpenter
[not found] ` <CAOiHx=k87c_bFqFtJ7zJc9HxnjOEr2oMofNUsLkQbfQPrC04hQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2013-12-06 14:12 ` [patch v2] " Dan Carpenter
[not found] ` <20131206141212.GA956-mgFCXtclrQlZLf2FXnZxJA@public.gmane.org>
2013-12-06 14:48 ` Jonas Gorski
2013-12-09 17:24 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131209172440.GA29268@sirena.org.uk \
--to=broonie@kernel.org \
--cc=dan.carpenter@oracle.com \
--cc=jogo@openwrt.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox