From: Dan Carpenter <dan.carpenter@oracle.com>
To: kernel-janitors@vger.kernel.org
Subject: [patch] skd: remove unneeded NULL check in skd_acquire_msix()
Date: Thu, 30 Jan 2014 11:57:45 +0000 [thread overview]
Message-ID: <20140130115745.GH12734@elgon.mountain> (raw)
kfree() takes NULL pointers and also the variable can never be NULL
here anyway.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/block/skd_main.c b/drivers/block/skd_main.c
index eb6e1e0e8db2..5ca729e6f644 100644
--- a/drivers/block/skd_main.c
+++ b/drivers/block/skd_main.c
@@ -4013,8 +4013,7 @@ static int skd_acquire_msix(struct skd_device *skdev)
return 0;
msix_out:
- if (entries)
- kfree(entries);
+ kfree(entries);
skd_release_msix(skdev);
return rc;
}
reply other threads:[~2014-01-30 11:57 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140130115745.GH12734@elgon.mountain \
--to=dan.carpenter@oracle.com \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox